On 5/20/07, Stefan Richter <[email protected]> wrote:
Satyam Sharma wrote:
> On 5/20/07, Stefan Richter <[email protected]> wrote:
>> However you fix it --- don't remove "depends on" or "select". You can
>> interchange them, but not remove them, unless there wasn't a dependency
>> to begin with.
>
> They _can_ be removed, with absolutely no build failures at all, because
> of the "default y if ..." on the dependency that is defined in some
> arch/.../Kconfig.
You are right, they can be removed, and the Kconfig files can be turned
into an unmaintainable mess.
A requires B
Maintainable.
B serves A
Logically equivalent, yet unmaintainable.
Well, whether it is readable / maintainable is subjective and hence
debatable. I was only answering your *completely misplaced and
incorrect* original comment against the patch where you claimed
that the patch was "totally wrong" because of the way it removed
the "select" ... etc ...
And remember, like I said already, the whole _idea_ is such arch-
specific helper code be not mentioned from arch-agnostic Kconfig
files. You may not like it, but this is the standard / most common way
such cases are handled for tons of other cases in arch/.... Which
is why Adrian's way of solving this (shifting all such arch-specific
helper symbols also to drivers/... and then using depends on select
on it) is not viable.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
