On 5/20/07, Satyam Sharma <[email protected]> wrote:
On 5/20/07, Stefan Richter <[email protected]> wrote:
> Satyam Sharma wrote:
> > A combined patch for all of those on top of 22-rc2 (adding Signed-off-by's
> > for original authors too):
> >
> > Signed-off-by: Kumar Gala <[email protected]>
> > Signed-off-by: Simon Horman <[email protected]>
> > Signed-off-by: Satyam Sharma <[email protected]>
>
> [...]
>
> Adrian already commented on this. Let me just add that these above
> changes are in so far *totally wrong* as they remove the "depends on
> XYZ" which is implied by "select XYZ".
Did you even try this patch?
Did you try to select UCC_GETH and see if UCC_FAST got
automatically selected or not?
Did you get any build problems (or bogus warnings, for that matter)?
Have you ever looked into arch/.../Kconfig's?
> Remember, "select" is like "depends on", just with the added twist that
> the 'make snafuconfig' scripts are instructed to (a) not hide the
> depending option from the user and (b) try to enable the dependency for
> the user if he tries to enable the depending option.
This is precisely what happens with this patch too.
Believe me, just go ahead and try it.
Report any errors, dissatisfaction, etc, if any.
Thanks.
[ Just to add: ]
You'll learn about the "default .. if .." Kconfig idiom after you try this, but
when this patch works for you, an Acked-by would also be nice, thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
