Re: [PATCH 2/3] m68k: compile fix - ADBREQ_RAW missing declaration

[Brad Boyer <flar@allandria.com>]

On Thu, Dec 22, 2005 at 05:06:55AM +0000, Al Viro wrote:
> On Thu, Dec 15, 2005 at 12:05:21PM -0800, Brad Boyer wrote:
> > I would like to stop using adb_request in mac/misc.c as well, but it's not
> > as simple as just changing it to use cuda_request and pmu_request. That
> > should do it for the cuda and pmu based models, but the egret (Mac IIsi
> > and friends) based models get left out by that fix. If noone else looks
> > at it before me, I'll check this out after I fix some other stuff related
> > to m68k mac support.
> 
> OK...  AFAICS, patch I've just posted to l-k and linux-m68k (subject:
> [PATCH 04/36] m68k: switch mac/misc.c to direct use of appropriate
> cuda/pmu/maciisi requests) should so it.  Do you have any problems with
> that variant?

I don't have any big issues with it. However, I am not at home right now
and can't actually try it out on real hardware. It looks like it should
work as well as the version it is replacing. I'm pretty sure the IIsi
case was broken before. I think we should go ahead and commit this to
get rid of the issues it fixes, and then come back to it later and take
another pass at it to fix the fact that it has never worked in 2.6 on
some models. It's better than nothing.

	Brad Boyer
	flar@allandria.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/