Re: [PATCH 2/3] m68k: compile fix - ADBREQ_RAW missing declaration

[Al Viro <viro@ftp.linux.org.uk>]

On Thu, Dec 15, 2005 at 06:14:05PM +0000, Al Viro wrote:
> >From my reading of the code it's a way for mac/misc.c to send a packet that
> starts with CUDA_PACKET or PMU_PACKET instead of ADB_PACKET, but otherwise
> is the same as normal adb_request() ones...
> 
> Used for access to timer, nvram, etc. - looks like that puppy used to
> use the same protocol for more than just ADB and the first byte of packet
> really selects the destination...

After reading some more...  Is there any reason why mac/misc.c can't
simply use cuda_request() and pmu_request() instead?  At least for
read/write for time and nvram we end up with identical sequence of
operations anyway - if you expand the calls in
        adb_request((struct adb_request *) &req, NULL,
                        ADBREQ_RAW|ADBREQ_SYNC,
                        2, CUDA_PACKET, CUDA_GET_TIME);
[m68k]
and
        if (cuda_request(&req, NULL, 2, CUDA_PACKET, CUDA_GET_TIME) < 0)
		/* bail out */
        while (!req.complete)
                cuda_poll();
[ppc]
until you get to call of cuda_write(), you'll see the same code.  Come
to think of that...  Shouldn't the ifdefs for CONFIG_ADB_PMU in there be for
CONFIG_ADB_PMU68?  The former depends on PMAC_PPC, so it's not particulary
useful thing to check on m68k...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/