Re: [PATCH] use kzalloc instead of malloc+memset

Andrew wrote:
> It hurts readability.  Quick question: is this code correct?
> 
> 	dev = kmalloc(sizeof(struct net_device), GFP_KERNEL);

And it hurts maintainability.  If someone changes 'dev' so
that it is no longer of type 'struct net_device', then they
risk missing this allocation, and introducing what could be
a nasty memory corruption kernel bug.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <[email protected]> 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] use kzalloc instead of malloc+memset
    • From: Bernd Petrovitsch <[email protected]>

• References:
  • [PATCH] use kzalloc instead of malloc+memset
    • From: Lion Vollnhals <[email protected]>
  • Re: [PATCH] use kzalloc instead of malloc+memset
    • From: Jiri Slaby <[email protected]>
  • Re: [PATCH] use kzalloc instead of malloc+memset
    • From: Pekka Enberg <[email protected]>
  • Re: [PATCH] use kzalloc instead of malloc+memset
    • From: Dmitry Torokhov <[email protected]>
  • Re: [PATCH] use kzalloc instead of malloc+memset
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [patch 9/11] net: dst_entry.refcount, use, lastuse to use alloc_percpu
• Next by Date: Re: Kernel 2.6.13 BUG tg3.c:2805 = crash (this one isn't tainted)
• Previous by thread: Re: [PATCH] use kzalloc instead of malloc+memset
• Next by thread: Re: [PATCH] use kzalloc instead of malloc+memset
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]