On Tue, 2005-09-13 at 16:28 -0700, Paul Jackson wrote:
> Andrew wrote:
> > It hurts readability. Quick question: is this code correct?
> >
> > dev = kmalloc(sizeof(struct net_device), GFP_KERNEL);
>
> And it hurts maintainability. If someone changes 'dev' so
> that it is no longer of type 'struct net_device', then they
'struct net_device *'
> risk missing this allocation, and introducing what could be
> a nasty memory corruption kernel bug.
SCNR,
Bernd
--
Firmix Software GmbH http://www.firmix.at/
mobil: +43 664 4416156 fax: +43 1 7890849-55
Embedded Linux Development and Services
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
|
![Powered by Linux](/button_01.gif) |