Re: [PATCH] use kzalloc instead of malloc+memset

On Monday 12 September 2005 23:43, Pekka Enberg wrote:
> On 9/13/05, Jiri Slaby <[email protected]> wrote:
> > >-      cls = kmalloc(sizeof(struct class), GFP_KERNEL);
> > >+      cls = kzalloc(sizeof(struct class), GFP_KERNEL);
> > >
> > >
> > maybe, the better way is to write `*cls' instead of `struct class',
> > better for further changes
> 
> Please note that some maintainers don't like it. I at least could not
> sneak in patches like these to drivers/usb/ because I had changed
> sizeof.
> 

And given the fact that Greg maintains driver core it probably won't be
accepted here either :)

FWIW I also prefer spelling out the structure I am allocating.

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] use kzalloc instead of malloc+memset
    • From: Andrew Morton <[email protected]>

• References:
  • [PATCH] use kzalloc instead of malloc+memset
    • From: Lion Vollnhals <[email protected]>
  • Re: [PATCH] use kzalloc instead of malloc+memset
    • From: Jiri Slaby <[email protected]>
  • Re: [PATCH] use kzalloc instead of malloc+memset
    • From: Pekka Enberg <[email protected]>

• Prev by Date: [patch 1/2] IRDA: nsc-ircc - clean up whitespace damage
• Next by Date: Re: 2.6.14-rc1 breaks tg3 on ia64
• Previous by thread: Re: [PATCH] use kzalloc instead of malloc+memset
• Next by thread: Re: [PATCH] use kzalloc instead of malloc+memset
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]