Re: [Patch](Resend) mm/sparse.c: Improve the error handling for sparse_add_one_section()

On Tue, 2007-11-27 at 10:26 +0800, WANG Cong wrote:
> 
> @@ -414,7 +418,7 @@ int sparse_add_one_section(struct zone *
>  out:
>         pgdat_resize_unlock(pgdat, &flags);
>         if (ret <= 0)
> -               __kfree_section_memmap(memmap, nr_pages);
> +               kfree(usemap);
>         return ret;
>  }
>  #endif 

Why did you get rid of the memmap free here?  A bad return from
sparse_init_one_section() indicates that we didn't use the memmap, so it
will leak otherwise.

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [Patch](Resend) mm/sparse.c: Improve the error handling for sparse_add_one_section()
    • From: WANG Cong <[email protected]>

• References:
  • Re: [Patch] mm/sparse.c: Check the return value of sparse_index_alloc().
    • From: Dave Hansen <[email protected]>
  • [Patch] mm/sparse.c: Improve the error handling for sparse_add_one_section()
    • From: WANG Cong <[email protected]>
  • Re: [Patch] mm/sparse.c: Improve the error handling for sparse_add_one_section()
    • From: Yasunori Goto <[email protected]>
  • [Patch](Resend) mm/sparse.c: Improve the error handling for sparse_add_one_section()
    • From: WANG Cong <[email protected]>

• Prev by Date: tcsetattr(fd, TCSAFLUSH) on an O_ASYNC pts device always fails
• Next by Date: Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.
• Previous by thread: Re: [Patch](Resend) mm/sparse.c: Improve the error handling for sparse_add_one_section()
• Next by thread: Re: [Patch](Resend) mm/sparse.c: Improve the error handling for sparse_add_one_section()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]