Re: [Patch] mm/sparse.c: Improve the error handling for sparse_add_one_section()

Hi, Cong-san.

>  	ms->section_mem_map |= SECTION_MARKED_PRESENT;
>  
>  	ret = sparse_init_one_section(ms, section_nr, memmap, usemap);
>  
>  out:
>  	pgdat_resize_unlock(pgdat, &flags);
> -	if (ret <= 0)
> -		__kfree_section_memmap(memmap, nr_pages);
> +
>  	return ret;
>  }
>  #endif

Hmm. When sparse_init_one_section() returns error, memmap and 
usemap should be free.

Thanks for your fixing.

-- 
Yasunori Goto 


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • [Patch](Resend) mm/sparse.c: Improve the error handling for sparse_add_one_section()
    • From: WANG Cong <[email protected]>

• References:
  • Re: [Patch] mm/sparse.c: Check the return value of sparse_index_alloc().
    • From: Dave Hansen <[email protected]>
  • [Patch] mm/sparse.c: Improve the error handling for sparse_add_one_section()
    • From: WANG Cong <[email protected]>

• Prev by Date: Re: [PATCH 2/4] fib_semantics: kmalloc + memset conversion to kzalloc
• Next by Date: Re: [PATCH 1/4] xfrm_hash: kmalloc + memset conversion to kzalloc
• Previous by thread: [Patch] mm/sparse.c: Improve the error handling for sparse_add_one_section()
• Next by thread: [Patch](Resend) mm/sparse.c: Improve the error handling for sparse_add_one_section()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]