Re: [Patch](Resend) mm/sparse.c: Improve the error handling for sparse_add_one_section()

>  	ret = sparse_init_one_section(ms, section_nr, memmap, usemap);
> @@ -414,7 +418,7 @@ int sparse_add_one_section(struct zone *
>  out:
>  	pgdat_resize_unlock(pgdat, &flags);
>  	if (ret <= 0)
> -		__kfree_section_memmap(memmap, nr_pages);
> +		kfree(usemap);
>  	return ret;
>  }
>  #endif
> 

I guess you think __kfree_section_memmap() is not necessary due to
no implementation. But, it is still available when
CONFIG_SPARSEMEM_VMEMMAP is off. So, it should not be removed.


Bye.

-- 
Yasunori Goto 


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • Re: [Patch] mm/sparse.c: Improve the error handling for sparse_add_one_section()
    • From: Yasunori Goto <[email protected]>
  • [Patch](Resend) mm/sparse.c: Improve the error handling for sparse_add_one_section()
    • From: WANG Cong <[email protected]>

• Prev by Date: Re: [PATCH 2/3] [POWERPC] fsl_soc: add support for gianfar for fixed-link property
• Next by Date: [patch] Clean hungarian notation from timers
• Previous by thread: [Patch](Resend) mm/sparse.c: Improve the error handling for sparse_add_one_section()
• Next by thread: Re: [Patch](Resend) mm/sparse.c: Improve the error handling for sparse_add_one_section()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]