Re: [PATCH 1/3] VFS: apply coding standards to fs/ioctl.c

On Sun, Oct 28, 2007 at 07:57:47PM -0700, Daniel Phillips wrote:
> On 10/28/07, Christoph Hellwig <[email protected]> wrote:
> > While you're at it, it's probably worth splitting this out into
> > a small helper function.
> 
> Why? Is the same pattern called from more than one place?

Becauase it's a lot more readable.  ioctl subcommands are invidividual
functionality, and separating them out into small self-contained functions
makes the code a lot more readable.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] 0/3 fs/ioctl.c coding style, rename vfs_ioctl/do_ioctl
    • From: Erez Zadok <[email protected]>
  • [PATCH 1/3] VFS: apply coding standards to fs/ioctl.c
    • From: Erez Zadok <[email protected]>
  • Re: [PATCH 1/3] VFS: apply coding standards to fs/ioctl.c
    • From: Christoph Hellwig <[email protected]>
  • Re: [PATCH 1/3] VFS: apply coding standards to fs/ioctl.c
    • From: "Daniel Phillips" <[email protected]>

• Prev by Date: Re: [PATCH 1/3] VFS: apply coding standards to fs/ioctl.c
• Next by Date: Re: vm_ops.page_mkwrite() fails with vmalloc on 2.6.23
• Previous by thread: Re: [PATCH 1/3] VFS: apply coding standards to fs/ioctl.c
• Next by thread: [PATCH 3/3] Unionfs: use vfs_ioctl
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]