Re: [PATCH] libata drain fifo on stuck DRQ HSM violation

Alan Cox wrote:

Why 512 words ?

Though I have queued Mark's patch to be applied, my gut feeling would lean towards a single DRQ block, rather than 512.

Why not just work from the old IDE code.

 	ata_altstatus(ap);
-	ata_chk_status(ap);
+	ata_drain_fifo(ap, qc);

ap->ops->cleanup();

might be wiser

If someone needs that, they can override the error handler with their own. No need for a new op.

PDC202xx needs

Alan, you're the expert there (my condolences!).
Can you generate a fix for the PDC202xx to go with this?

Cheers
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • Stardom SATA HSM violation
    • From: Bryan Woods <[email protected]>
  • Re: Stardom SATA HSM violation
    • From: "Michal Piotrowski" <[email protected]>
  • Re: Stardom SATA HSM violation
    • From: Tejun Heo <[email protected]>
  • Re: Stardom SATA HSM violation
    • From: Andrew Morton <[email protected]>
  • Re: Stardom SATA HSM violation
    • From: Mark Lord <[email protected]>
  • Re: Stardom SATA HSM violation
    • From: Tejun Heo <[email protected]>
  • Re: Stardom SATA HSM violation
    • From: Mark Lord <[email protected]>
  • Re: Stardom SATA HSM violation
    • From: Tejun Heo <[email protected]>
  • Re: Stardom SATA HSM violation
    • From: Alan Cox <[email protected]>
  • Re: Stardom SATA HSM violation
    • From: Tejun Heo <[email protected]>
  • Re: Stardom SATA HSM violation
    • From: Jeff Garzik <[email protected]>
  • Re: Stardom SATA HSM violation
    • From: Tejun Heo <[email protected]>
  • [PATCH] libata drain fifo on stuck DRQ HSM violation
    • From: Mark Lord <[email protected]>
  • Re: [PATCH] libata drain fifo on stuck DRQ HSM violation
    • From: Alan Cox <[email protected]>
  • Re: [PATCH] libata drain fifo on stuck DRQ HSM violation
    • From: Jeff Garzik <[email protected]>
  • Re: [PATCH] libata drain fifo on stuck DRQ HSM violation
    • From: Alan Cox <[email protected]>

• Prev by Date: Re: A unresponsive file system can hang all I/O in the system on linux-2.6.23-rc6 (dirty_thresh problem?)
• Next by Date: Re: [patch] Combine path_put and path_put_conditional
• Previous by thread: Re: [PATCH] libata drain fifo on stuck DRQ HSM violation
• Next by thread: Re: Stardom SATA HSM violation
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]