Alan Cox wrote:
Drain up to 512 words from host/bridge FIFO on stuck DRQ HSM violation, rather than just getting stuck there forever.Why 512 words ?
Though I have queued Mark's patch to be applied, my gut feeling would lean towards a single DRQ block, rather than 512.
ata_altstatus(ap); - ata_chk_status(ap); + ata_drain_fifo(ap, qc);ap->ops->cleanup(); might be wiser
If someone needs that, they can override the error handler with their own. No need for a new op.
Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- References:
- Stardom SATA HSM violation
- From: Bryan Woods <[email protected]>
- Re: Stardom SATA HSM violation
- From: "Michal Piotrowski" <[email protected]>
- Re: Stardom SATA HSM violation
- From: Tejun Heo <[email protected]>
- Re: Stardom SATA HSM violation
- From: Andrew Morton <[email protected]>
- Re: Stardom SATA HSM violation
- From: Mark Lord <[email protected]>
- Re: Stardom SATA HSM violation
- From: Tejun Heo <[email protected]>
- Re: Stardom SATA HSM violation
- From: Mark Lord <[email protected]>
- Re: Stardom SATA HSM violation
- From: Tejun Heo <[email protected]>
- Re: Stardom SATA HSM violation
- From: Alan Cox <[email protected]>
- Re: Stardom SATA HSM violation
- From: Tejun Heo <[email protected]>
- Re: Stardom SATA HSM violation
- From: Jeff Garzik <[email protected]>
- Re: Stardom SATA HSM violation
- From: Tejun Heo <[email protected]>
- [PATCH] libata drain fifo on stuck DRQ HSM violation
- From: Mark Lord <[email protected]>
- Re: [PATCH] libata drain fifo on stuck DRQ HSM violation
- From: Alan Cox <[email protected]>
- Stardom SATA HSM violation
- Prev by Date: regression in 2.6.23-rc8 - power off failed on old laptop
- Next by Date: Re: [PATCH][resend] PCI: fix IDE legacy mode resources
- Previous by thread: Re: [PATCH] libata drain fifo on stuck DRQ HSM violation (try#2)
- Next by thread: Re: [PATCH] libata drain fifo on stuck DRQ HSM violation
- Index(es):
 |