On 30 May, Robert P. J. Day wrote: > On Wed, 30 May 2007, Adrian Bunk wrote: >> Considering that we export this struct to usespace, I don't think >> renaming a member without a good reason is a good idea (but adding a >> comment makes sense). [...] > i thought i was submitting a fairly innocuous patch. live and learn. I've could have seen that it is defined outside #ifdef __KERNEL__. From: Stefan Richter <[email protected]> Subject: fs: clarify "dummy" member in struct inodes_stat_t Signed-off-by: Stefan Richter <[email protected]> --- linux.orig/include/linux/fs.h +++ linux/include/linux/fs.h @@ -44,7 +44,7 @@ extern int get_max_files(void); struct inodes_stat_t { int nr_inodes; int nr_unused; - int dummy[5]; + int dummy[5]; /* padding for sysctl ABI compatibility */ }; extern struct inodes_stat_t inodes_stat; -- Stefan Richter -=====-=-=== -=-= ====- http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- References:
- [PATCH] FILESYSTEMS: Delete unused "int dummy[5]" from inodes_stat_t.
- From: "Robert P. J. Day" <[email protected]>
- Re: [PATCH] FILESYSTEMS: Delete unused "int dummy[5]" from inodes_stat_t.
- From: Andrew Morton <[email protected]>
- Re: [PATCH] FILESYSTEMS: Delete unused "int dummy[5]" from inodes_stat_t.
- From: "Robert P. J. Day" <[email protected]>
- Re: [PATCH] FILESYSTEMS: Delete unused "int dummy[5]" from inodes_stat_t.
- From: Randy Dunlap <[email protected]>
- Re: [PATCH] FILESYSTEMS: Delete unused "int dummy[5]" from inodes_stat_t.
- From: "Robert P. J. Day" <[email protected]>
- Re: [PATCH] FILESYSTEMS: Delete unused "int dummy[5]" from inodes_stat_t.
- From: Randy Dunlap <[email protected]>
- Re: [PATCH] FILESYSTEMS: Delete unused "int dummy[5]" from inodes_stat_t.
- From: "Josh Boyer" <[email protected]>
- Re: [PATCH] FILESYSTEMS: Delete unused "int dummy[5]" from inodes_stat_t.
- From: Randy Dunlap <[email protected]>
- Re: [PATCH] FILESYSTEMS: Delete unused "int dummy[5]" from inodes_stat_t.
- From: Stefan Richter <[email protected]>
- Re: [PATCH] FILESYSTEMS: Delete unused "int dummy[5]" from inodes_stat_t.
- From: Adrian Bunk <[email protected]>
- Re: [PATCH] FILESYSTEMS: Delete unused "int dummy[5]" from inodes_stat_t.
- From: "Robert P. J. Day" <[email protected]>
- [PATCH] FILESYSTEMS: Delete unused "int dummy[5]" from inodes_stat_t.
- Prev by Date: Re: [PATCH 4/5] serial: convert early_uart to earlycon for 8250
- Next by Date: Re: Syslets, Threadlets, generic AIO support, v6
- Previous by thread: Re: [PATCH] FILESYSTEMS: Delete unused "int dummy[5]" from inodes_stat_t.
- Next by thread: Re: [trivial PATCH, updated] fs: clarify "dummy" member in struct inodes_stat_t
- Index(es):
 |