Re: [trivial PATCH, updated] fs: clarify "dummy" member in struct inodes_stat_t

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Stefan Richter wrote:
On 30 May, Robert P. J. Day wrote:
On Wed, 30 May 2007, Adrian Bunk wrote:
Considering that we export this struct to usespace, I don't think
renaming a member without a good reason is a good idea (but adding a
comment makes sense).
[...]
i thought i was submitting a fairly innocuous patch.  live and learn.

I've could have seen that it is defined outside #ifdef __KERNEL__.


From: Stefan Richter <[email protected]>
Subject: fs: clarify "dummy" member in struct inodes_stat_t

Acked-by: Randy Dunlap <[email protected]>

Signed-off-by: Stefan Richter <[email protected]>
--- linux.orig/include/linux/fs.h
+++ linux/include/linux/fs.h
@@ -44,7 +44,7 @@ extern int get_max_files(void);
 struct inodes_stat_t {
 	int nr_inodes;
 	int nr_unused;
-	int dummy[5];
+	int dummy[5];		/* padding for sysctl ABI compatibility */
 };
 extern struct inodes_stat_t inodes_stat;


--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux