Re: [PATCH] ubi: kill homegrown endian macros

[Al Viro <viro@ftp.linux.org.uk>]

On Thu, May 17, 2007 at 02:33:34PM -0700, David Miller wrote:
> From: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
> Date: Thu, 17 May 2007 17:14:26 -0400
> 
> > On 5/17/07, Al Viro <viro@ftp.linux.org.uk> wrote:
> > >
> > > Ahem...  So what does
> > >        x |= y;
> > > turns into with that approach?
> > 
> > Do we want to do such kind of operations on endian-annotated data? I'd
> > imagine you want to convert ot host-endianess first anyway.
> 
> Generally you don't, if 'x' and 'y' are both in the needed
> endinaness already, there is no reason to convert anything.

BTW, if you have two independently defined bitwise types, sparse
will complain about mixing them, so you still have protection against
mixing unrelated types that happen to have the same endianness.

Folks, just doing annotations of net/* had been large enough and it
mostly had been about annotating declarations.  If we have to rewrite
every sodding place where we happen to do bitwise operations on those...
Forget about it.  BTW, another fun kind of places is comparing for
equality - also adds a fsckload of lines to rewrite^Wobscure.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/