Re: [PATCH] ubi: kill homegrown endian macros

[Al Viro <viro@ftp.linux.org.uk>]

On Thu, May 17, 2007 at 10:29:31AM -0700, Andrew Morton wrote:
> On Thu, 17 May 2007 18:09:50 +0300 Artem Bityutskiy <dedekind@infradead.org> wrote:
> 
> > On Thu, 2007-05-17 at 16:56 +0200, Christoph Hellwig wrote:
> > > On Thu, May 17, 2007 at 05:50:43PM +0300, Artem Bityutskiy wrote:
> > > > Christoph,
> > > > 
> > > > On Thu, 2007-05-17 at 16:32 +0200, Christoph Hellwig wrote:
> > > > > Kill ubis homegrown endianess handling crap and replace it with
> > > > > the normal kernel endianess handling.
> > > > 
> > > > Err,__be32 and the company are just sparse things, while I have compiler
> > > > checks with my struct ubi32_t and friends. JFFS2 also uses the same
> > > > technique. Why do you force me to rely on sparse instead instead of
> > > > compiler?
> > > 
> > > Yes.  Like all other code in the kernel aswell.
> > 
> > Andrew, may I please have your ack that I absolutely have to use __be32
> > instead of my own types since Christoph tends to provide no explanation
> > to his requests.
> 
> umm..  I'd say what you've done in there is an improvement to the exiting
> stuff: getting gcc to check it is better than having to use sparse.

Ahem...  So what does
	x |= y;
turns into with that approach?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/