Re: strncpy optimalisation? (lib/string.c)

Folkert van Heusden wrote:
> This one (tested in test-code seperate from kernel) works:

No it doesn't!

strncpy() guarantees that the entire destination buffer is written to.
If you call
	strncpy(dest, "foo", 10000)
then you MUST write to 10000 bytes of memory, or your strncpy() is buggy.

Your patches basically turn strncpy() into strlcpy().  Don't do that.
They're separate functions for a reason.

-Mitch
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: strncpy optimalisation? (lib/string.c)
    • From: Folkert van Heusden <[email protected]>

• References:
  • strncpy optimalisation? (lib/string.c)
    • From: Folkert van Heusden <[email protected]>
  • Re: strncpy optimalisation? (lib/string.c)
    • From: Willy Tarreau <[email protected]>
  • Re: strncpy optimalisation? (lib/string.c)
    • From: Folkert van Heusden <[email protected]>

• Prev by Date: Re: optimalisation for strlcpy (lib/string.c)
• Next by Date: Re: [PATCH 2/3] Import fw-ohci driver.
• Previous by thread: Re: strncpy optimalisation? (lib/string.c)
• Next by thread: Re: strncpy optimalisation? (lib/string.c)
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]