Re: [PATCH 2/3] Import fw-ohci driver.

Stefan Richter wrote:

Kristian Høgsberg wrote:

Yup, I've done away with the bitfields and switched to a mix of __le16
and __le32 struct fields.

I suppose the struct should get __attribute__((packed)) then.

I guess it wouldn't harm, but is it really necessary? Would gcc ever insert padding here, all the 32 bit fields a 32 bit aligned, and so are the 16 bit fields.

But is the order of two adjacent __le16 fields (i.e. two halves of a
quadlet) independent of host byte order?

Yeah, it works for both be and le cpus. The layout is le specific, which is how the host controller wants it.

cheers,
Kristian

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 2/3] Import fw-ohci driver.
    • From: Stefan Richter <[email protected]>

• References:
  • [PATCH 0/3] New firewire stack
    • From: "Kristian Høgsberg" <[email protected]>
  • [PATCH 2/3] Import fw-ohci driver.
    • From: "Kristian Høgsberg" <[email protected]>
  • Re: [PATCH 2/3] Import fw-ohci driver.
    • From: Jeff Garzik <[email protected]>
  • Re: [PATCH 2/3] Import fw-ohci driver.
    • From: Kristian Høgsberg <[email protected]>
  • Re: [PATCH 2/3] Import fw-ohci driver.
    • From: Stefan Richter <[email protected]>

• Prev by Date: Re: strncpy optimalisation? (lib/string.c)
• Next by Date: Re: optimalisation for strlcpy (lib/string.c)
• Previous by thread: Re: [PATCH 2/3] Import fw-ohci driver.
• Next by thread: Re: [PATCH 2/3] Import fw-ohci driver.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]