Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro

On Sat, Nov 25, 2006 at 05:17:08PM -0800, Roland Dreier wrote:
>  > 	(typeof(x))((x + a - 1) & ~(a - 1ULL))
> 
> Yes I was being stupid thinking I needed a temporary variable to use
> typeof.  But what does the cast to typeof(x) accomplish if we write
> things the way you suggested above?  It seems that the right things is
> really just
> 
> 	(((x) + (a) - 1) & ~((typeof(x)) (a) - 1))

Better have type of result independent of that of a.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- [PATCH] Avoid truncating to 'long' in ALIGN() macro
  - From: Roland Dreier <[email protected]>
- Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
  - From: David Miller <[email protected]>
- Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
  - From: Roland Dreier <[email protected]>
- Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
  - From: David Miller <[email protected]>
- Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
  - From: Al Viro <[email protected]>
- Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
  - From: Roland Dreier <[email protected]>

Prev by Date: Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
Next by Date: Re: Entropy Pool Contents
Previous by thread: Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
Next by thread: Overriding X on panic
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]