Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro

• To: David Miller <[email protected]>
• Subject: Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
• From: Roland Dreier <[email protected]>
• Date: Sat, 25 Nov 2006 14:56:22 -0800
• Authentication-results: sj-dkim-6; [email protected]; dkim=pass ( sig from cisco.com/sjdkim6002 verified; );
• Cc: [email protected], [email protected], [email protected], [email protected]
• Dkim-signature: v=0.5; a=rsa-sha256; q=dns/txt; l=603; t=1164495384; x=1165359384; c=relaxed/simple; s=sjdkim6002; h=Content-Type:From:Subject:Content-Transfer-Encoding:MIME-Version; d=cisco.com; [email protected]; z=From:=20Roland=20Dreier=20<[email protected]> |Subject:=20Re=3A=20[PATCH]=20Avoid=20truncating=20to=20'long'=20in=20ALI GN()=20macro |Sender:=20; bh=8aEWCA9biPBFa6cYtn7BpStef0MDDKy5Wv3Pfnp3c3s=; b=jQFgVDAsGAR/6New+bhj6ZNdFHa4BkbOslI0aEyTG/zYTFxbIpwRCTlnolurMuUDYWeQp3CJ 8knca+R5qq3kNuQlyScsBwDgDouhPxmtrlSdAW+4q3/VRXvOnLaY9Lm+;
• In-reply-to: <[email protected]> (David Miller's message of "Fri, 24 Nov 2006 22:07:46 -0800 (PST)")
• References: <[email protected]> <[email protected]>
• Sender: [email protected]
• User-agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.19 (linux)

 > Perhaps a better way to fix this is to use
 > typeof() like other similar macros do.

I tried doing

#define ALIGN(x,a)				\
	({					\
		typeof(x) _a = (a);		\
		((x) + _a - 1) & ~(_a - 1);	\
	})

but that won't compile because of <net/neighbour.h>:

	unsigned char		ha[ALIGN(MAX_ADDR_LEN, sizeof(unsigned long))];

gcc says:

/scratch/Ksrc/linux-merge/include/net/neighbour.h:104: error: braced-group within expression allowed only inside a function

I guess that could be fixed by changing that declaration but now this
is starting to feel like early 2.6.20 material.

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
    • From: David Miller <[email protected]>

• References:
  • [PATCH] Avoid truncating to 'long' in ALIGN() macro
    • From: Roland Dreier <[email protected]>
  • Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
    • From: David Miller <[email protected]>

• Prev by Date: Re: [PATCH 0/4] atl1: Revised Attansic L1 ethernet driver
• Next by Date: Re: [PATCH] Revert "[IRDA]: Lockdep fix."
• Previous by thread: Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
• Next by thread: Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]