Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro

• To: Al Viro <[email protected]>
• Subject: Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
• From: Roland Dreier <[email protected]>
• Date: Sat, 25 Nov 2006 17:17:08 -0800
• Authentication-results: sj-dkim-2; [email protected]; dkim=pass ( sig from cisco.com/sjdkim2002 verified; );
• Cc: David Miller <[email protected]>, [email protected], [email protected], [email protected], [email protected]
• Dkim-signature: v=0.5; a=rsa-sha256; q=dns/txt; l=326; t=1164503829; x=1165367829; c=relaxed/simple; s=sjdkim2002; h=Content-Type:From:Subject:Content-Transfer-Encoding:MIME-Version; d=cisco.com; [email protected]; z=From:=20Roland=20Dreier=20<[email protected]> |Subject:=20Re=3A=20[PATCH]=20Avoid=20truncating=20to=20'long'=20in=20ALI GN()=20macro |Sender:=20; bh=abe7QKTBJMJPC7PIUR2OZhBibQh2EZ6egd5JsLe4rzw=; b=Q/coMJ1RPoDsrj2AqY5yo/k5dswAgv2Zhjj9PVPlWmn57TxNbxV6ztIFuiM9og67KXca91Lo MEyE9qKH/aq9JD80UJQnnw32Pvan+Z8NzJzunhDIx0LNUDp4dLNKmPol;
• In-reply-to: <[email protected]> (Al Viro's message of "Sun, 26 Nov 2006 01:10:14 +0000")
• References: <[email protected]> <[email protected]> <[email protected]> <[email protected]> <[email protected]>
• Sender: [email protected]
• User-agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.19 (linux)

 > 	(typeof(x))((x + a - 1) & ~(a - 1ULL))

Yes I was being stupid thinking I needed a temporary variable to use
typeof.  But what does the cast to typeof(x) accomplish if we write
things the way you suggested above?  It seems that the right things is
really just

	(((x) + (a) - 1) & ~((typeof(x)) (a) - 1))

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
    • From: Al Viro <[email protected]>

• References:
  • [PATCH] Avoid truncating to 'long' in ALIGN() macro
    • From: Roland Dreier <[email protected]>
  • Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
    • From: David Miller <[email protected]>
  • Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
    • From: Roland Dreier <[email protected]>
  • Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
    • From: David Miller <[email protected]>
  • Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
    • From: Al Viro <[email protected]>

• Prev by Date: [RFC: 2.6 patch] zd1211rw: possible cleanups
• Next by Date: Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
• Previous by thread: Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
• Next by thread: Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]