Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro

From: Roland Dreier <[email protected]>
Date: Sat, 25 Nov 2006 14:56:22 -0800

>  > Perhaps a better way to fix this is to use
>  > typeof() like other similar macros do.
> 
> I tried doing
> 
> #define ALIGN(x,a)				\
> 	({					\
> 		typeof(x) _a = (a);		\
> 		((x) + _a - 1) & ~(_a - 1);	\
> 	})
> 
> but that won't compile because of <net/neighbour.h>:

You would need to also cast the constants with typeof() to.

But yes, given the array sizing case in the neighbour code,
perhaps we can use your original patch for now.  Feel free
to push that to Linus.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
  - From: Al Viro <[email protected]>
- Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
  - From: Roland Dreier <[email protected]>

References:
- [PATCH] Avoid truncating to 'long' in ALIGN() macro
  - From: Roland Dreier <[email protected]>
- Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
  - From: David Miller <[email protected]>
- Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
  - From: Roland Dreier <[email protected]>

Prev by Date: Re: tty line discipline driver advice sought, to do a 1-byte header and 2-byte CRC checksum on GSM data
Next by Date: Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
Previous by thread: Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
Next by thread: Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]