Re: [PATCH 0/11] LTTng-core (basic tracing infrastructure) 0.5.108

i disagree. Consider the following example from LTT:

...

         trace_socket_sendmsg(sock, sock->sk->sk_family,
                 sock->sk->sk_type,
                 sock->sk->sk_protocol,
                 size);

...

what do the 5 extra lines introduced by trace_socket_sendmsg() tell us? Nothing. They mostly just duplicate the information i already have from the function declaration. They obscure the clear view of the function:

 ...

the resulting visual and structural redundancy hurts.

Couldn't that be easily fixed by just doing

	trace_socket_sendmsg(sock, size);

and have it work out which esoteric parts of the sock we want to trace,
and which we don't? Is much less visually invasive, and gives the same
effect.

M.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 0/11] LTTng-core (basic tracing infrastructure) 0.5.108
    • From: Ingo Molnar <[email protected]>

• References:
  • [PATCH 0/11] LTTng-core (basic tracing infrastructure) 0.5.108
    • From: Mathieu Desnoyers <[email protected]>
  • Re: [PATCH 0/11] LTTng-core (basic tracing infrastructure) 0.5.108
    • From: Ingo Molnar <[email protected]>
  • Re: [PATCH 0/11] LTTng-core (basic tracing infrastructure) 0.5.108
    • From: "Martin J. Bligh" <[email protected]>
  • Re: [PATCH 0/11] LTTng-core (basic tracing infrastructure) 0.5.108
    • From: Ingo Molnar <[email protected]>
  • Re: [PATCH 0/11] LTTng-core (basic tracing infrastructure) 0.5.108
    • From: Martin Bligh <[email protected]>
  • Re: [PATCH 0/11] LTTng-core (basic tracing infrastructure) 0.5.108
    • From: Ingo Molnar <[email protected]>
  • Re: [PATCH 0/11] LTTng-core (basic tracing infrastructure) 0.5.108
    • From: Michel Dagenais <[email protected]>
  • Re: [PATCH 0/11] LTTng-core (basic tracing infrastructure) 0.5.108
    • From: Ingo Molnar <[email protected]>

• Prev by Date: Re: [ltp] 2.6.18-rc6, SATA, resume from RAM
• Next by Date: Re: [Bug] 2.6.18-rc6-mm2 i386 trouble finding RSDT in get_memcfg_from_srat
• Previous by thread: Re: [PATCH 0/11] LTTng-core (basic tracing infrastructure) 0.5.108
• Next by thread: Re: [PATCH 0/11] LTTng-core (basic tracing infrastructure) 0.5.108
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]