Re: [PATCH 1/5] proc: Make the generation of the self symlink table driven.

Jan Engelhardt <[email protected]> writes:

>>>>> +	for (; nr < (ARRAY_SIZE(proc_base_stuff) - 1); filp->f_pos++, nr++) {
>>>>
>>> Also works without the () around ARRAY_SIZE(..)-1
>>
>>Sure.  But I don't really trust C precedence (because it is wrong)
>
> Wrong? In mathematics, "a < (b - 1)" also is equivalent to "a < b - 1".

In mathematics < is not an operation that yields a result in
the domain of integers.  So  "(a < b) - 1" is impossible.

Regardless this isn't a case where the C precedence is wrong.
"a < b | 1" is an example of C getting the precedence wrong.

Having to remember where C is wrong and in what circumstances is
harder than just putting in parenthesis.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 1/5] proc: Make the generation of the self symlink table driven.
    • From: Jan Engelhardt <[email protected]>

• References:
  • [PATCH 1/5] proc: Make the generation of the self symlink table driven.
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH 1/5] proc: Make the generation of the self symlink table driven.
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH 1/5] proc: Make the generation of the self symlink table driven.
    • From: Jan Engelhardt <[email protected]>
  • Re: [PATCH 1/5] proc: Make the generation of the self symlink table driven.
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH 1/5] proc: Make the generation of the self symlink table driven.
    • From: Jan Engelhardt <[email protected]>

• Prev by Date: BUG in sata_mv
• Next by Date: Re: re-reading the partition table on a "busy" drive
• Previous by thread: Re: [PATCH 1/5] proc: Make the generation of the self symlink table driven.
• Next by thread: Re: [PATCH 1/5] proc: Make the generation of the self symlink table driven.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]