Re: [PATCH 1/5] proc: Make the generation of the self symlink table driven.

>> +static struct pid_entry proc_base_stuff[] = {
>> +	NOD(PROC_TGID_INO, 	"self", S_IFLNK|S_IRWXUGO,
>> +		&proc_self_inode_operations, NULL, {}),
>> +	{}
>> +};
>
>We could save a bunch of bytes here.
>
>> +	/* Lookup the directory entry */
>> +	for (p = proc_base_stuff; p->name; p++) {
>
>By using ARRAY_SIZE here.
>
>> +	for (; nr < (ARRAY_SIZE(proc_base_stuff) - 1); filp->f_pos++, nr++) {
>
>like that does.

Also works without the () around ARRAY_SIZE(..)-1



Jan Engelhardt
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH 1/5] proc: Make the generation of the self symlink table driven.
  - From: [email protected] (Eric W. Biederman)

References:
- [PATCH 1/5] proc: Make the generation of the self symlink table driven.
  - From: [email protected] (Eric W. Biederman)
- Re: [PATCH 1/5] proc: Make the generation of the self symlink table driven.
  - From: Andrew Morton <[email protected]>

Prev by Date: Re: Re: [patch 6/6] process filtering for fault-injection capabilities
Next by Date: Re: [RFC] e-mail clients
Previous by thread: Re: [PATCH 1/5] proc: Make the generation of the self symlink table driven.
Next by thread: Re: [PATCH 1/5] proc: Make the generation of the self symlink table driven.
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]