Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes

On 8/9/06, Muli Ben-Yehuda <[email protected]> wrote:

> >If the concern is just the naming then change it to end _trylock
>
> We already have a thinkpad_ec_trylock() for the non-blocking
> variant.

thinkpad_ec_down_interruptible()?

Just ran out, of that sir,

If we'll need to lock away ACPI (just matter of time, my guess), we'll
stumble upon the non-interruptible down()s deep inside in the ACPI
code. So we can't guarantee and shouldn't promise it's really
interruptible.

It's not that strange that a function might fail even if it's named
"do_something()", you know. It's down() that forms an exception - it's
so simple we know it can't fail.

 Shem
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes
    • From: Muli Ben-Yehuda <[email protected]>

• References:
  • Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes
    • From: "Shem Multinymous" <[email protected]>
  • Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes
    • From: Muli Ben-Yehuda <[email protected]>
  • Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes
    • From: Pavel Machek <[email protected]>
  • Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes
    • From: Muli Ben-Yehuda <[email protected]>
  • Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes
    • From: "Shem Multinymous" <[email protected]>
  • Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes
    • From: Muli Ben-Yehuda <[email protected]>
  • Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes
    • From: "Shem Multinymous" <[email protected]>
  • Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes
    • From: Alan Cox <[email protected]>
  • Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes
    • From: "Shem Multinymous" <[email protected]>
  • Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes
    • From: Muli Ben-Yehuda <[email protected]>

• Prev by Date: Re: Suspend on Dell D420
• Next by Date: Re: modifying degraded raid 1 then re-adding other members is bad
• Previous by thread: Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes
• Next by thread: Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]