Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Pavel,

On 8/7/06, Pavel Machek <[email protected]> wrote:
> +     int total, ret;
> +     for (total=READ_TIMEOUT_MSECS; total>0; total-=RETRY_MSECS) {

Could we go from 0 to timeout, not the other way around?

Sure.
(That's actually vanilla hdapsd code, moved around...)


This actually changes userland interface... but that is probably okay.

Those two sysfs attributes were bogus. If anything used them (which I
very much doubt), it's a good thing we broke it.

OK on the rest.

 Shem
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux