Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes

On Tue, Aug 08, 2006 at 12:56:52PM +0000, Pavel Machek wrote:

> > > 	ret = thinkpad_ec_lock();
> > > 	if (ret)
> > > 		return ret;
> > 
> > Just in case someone was going to cut and paste, this will return with
> > the ec_lock taken.
> 
> Well, taking lock failed (hence error return) so I think code is
> correct.

Ugh, I missed that - it's called _lock(), but it's actually
down_interruptible(). Why not just get rid of the wrapper and call
down_interruptible() directly? That makes it obvious what's going on.

Cheers,
Muil
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes
    • From: "Shem Multinymous" <[email protected]>

• References:
  • [PATCH 00/12] ThinkPad embedded controller and hdaps drivers
    • From: Shem Multinymous <[email protected]>
  • [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes
    • From: Shem Multinymous <[email protected]>
  • Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes
    • From: Pavel Machek <[email protected]>
  • Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes
    • From: "Shem Multinymous" <[email protected]>
  • Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes
    • From: Björn Steinbrink <[email protected]>
  • Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes
    • From: Muli Ben-Yehuda <[email protected]>
  • Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes
    • From: Pavel Machek <[email protected]>

• Prev by Date: Re: [PATCH -rt DO NOT APPLY] Fix for tg3 networking lockup
• Next by Date: Re: [PATCH 08/12] hdaps: Add explicit hardware configuration functions
• Previous by thread: Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes
• Next by thread: Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]