On Wed, Jul 26, 2006 at 01:22:24PM -0700, Linus Torvalds wrote: > > Of course, that's why people want recursive locks in the first place, and > it's also why we've (largely successfully) have avoided them - it allows > for people being way too lazy about locking, and allows for really broken > schenarios like this. > > I wonder if we could just make the workqueue code just run with preemption > disabled - that should also automatically protect against any CPU hotplug Its probably ok for this case. before introducing the ugly recursion we did try the preempt_disable() for cpufreq, and it worked for most all governers with preempt_disable(), but powernowk8 called set_cpus_allowed() in the callback path that threw out a scheduling while in atomic BUG(). http://lkml.org/lkml/2005/10/31/239 > events on the local CPU (and I think "local CPU" is all that the wq code > cares about, no?) > > Linus -- Cheers, Ashok Raj - Open Source Technology Center - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- RE: [patch] Reorganize the cpufreq cpu hotplug locking to not be totally bizare
- From: "Langsdorf, Mark" <[email protected]>
- RE: [patch] Reorganize the cpufreq cpu hotplug locking to not be totally bizare
- References:
- Re: remove cpu hotplug bustification in cpufreq.
- From: Chuck Ebbert <[email protected]>
- Re: remove cpu hotplug bustification in cpufreq.
- From: Linus Torvalds <[email protected]>
- Re: remove cpu hotplug bustification in cpufreq.
- From: Ingo Molnar <[email protected]>
- Re: remove cpu hotplug bustification in cpufreq.
- From: Arjan van de Ven <[email protected]>
- Re: remove cpu hotplug bustification in cpufreq.
- From: Linus Torvalds <[email protected]>
- [patch] Reorganize the cpufreq cpu hotplug locking to not be totally bizare
- From: Arjan van de Ven <[email protected]>
- Re: [patch] Reorganize the cpufreq cpu hotplug locking to not be totally bizare
- From: Dave Jones <[email protected]>
- Re: [patch] Reorganize the cpufreq cpu hotplug locking to not be totally bizare
- From: Linus Torvalds <[email protected]>
- Re: [patch] Reorganize the cpufreq cpu hotplug locking to not be totally bizare
- From: Arjan van de Ven <[email protected]>
- Re: [patch] Reorganize the cpufreq cpu hotplug locking to not be totally bizare
- From: Linus Torvalds <[email protected]>
- Re: remove cpu hotplug bustification in cpufreq.
- Prev by Date: Re: the " 'official' point of view" expressed by kernelnewbies.org regarding reiser4 inclusion
- Next by Date: Re: [patch] Reorganize the cpufreq cpu hotplug locking to not be totally bizare
- Previous by thread: Re: [patch] Reorganize the cpufreq cpu hotplug locking to not be totally bizare
- Next by thread: RE: [patch] Reorganize the cpufreq cpu hotplug locking to not be totally bizare
- Index(es):
![]() |