Re: tty's use of file_list_lock and file_move

Jon Smirl wrote:

[...]
 extern struct tty_driver *ptm_driver;	/* Unix98 pty masters; for /dev/ptmx */
@@ -158,21 +157,21 @@ static struct tty_struct *alloc_tty_stru
 {
 	struct tty_struct *tty;

- tty = kmalloc(sizeof(struct tty_struct), GFP_KERNEL);

-	if (tty)
-		memset(tty, 0, sizeof(struct tty_struct));
+	tty = kmalloc(sizeof(*tty), GFP_KERNEL);

              ^^^^^^^
kzalloc?

I don't know this code very well, so you might be actually changing the initialization here. On the other hand, this might be just a simple bug...

--
Paulo Marques - www.grupopie.com

Pointy-Haired Boss: I don't see anything that could stand in our way.
           Dilbert: Sanity? Reality? The laws of physics?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: tty's use of file_list_lock and file_move
    • From: "Jon Smirl" <[email protected]>

• References:
  • tty's use of file_list_lock and file_move
    • From: "Jon Smirl" <[email protected]>
  • Re: tty's use of file_list_lock and file_move
    • From: "Jon Smirl" <[email protected]>
  • Re: tty's use of file_list_lock and file_move
    • From: Alan Cox <[email protected]>
  • Re: tty's use of file_list_lock and file_move
    • From: "Jon Smirl" <[email protected]>
  • Re: tty's use of file_list_lock and file_move
    • From: Alan Cox <[email protected]>
  • Re: tty's use of file_list_lock and file_move
    • From: "Jon Smirl" <[email protected]>
  • Re: tty's use of file_list_lock and file_move
    • From: "Jon Smirl" <[email protected]>
  • Re: tty's use of file_list_lock and file_move
    • From: Theodore Tso <[email protected]>
  • Re: tty's use of file_list_lock and file_move
    • From: "Jon Smirl" <[email protected]>
  • Re: tty's use of file_list_lock and file_move
    • From: Alan Cox <[email protected]>
  • Re: tty's use of file_list_lock and file_move
    • From: "Jon Smirl" <[email protected]>

• Prev by Date: [OT] Evolution use (was: Re: [discuss] Re: [PATCH] Allow all Opteron processors to change pstate at same time)
• Next by Date: Re: [PATCH 00/10] Kernel memory leak detector 0.8
• Previous by thread: Re: tty's use of file_list_lock and file_move
• Next by thread: Re: tty's use of file_list_lock and file_move
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]