Re: tty's use of file_list_lock and file_move

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/11/06, Paulo Marques <[email protected]> wrote:
Jon Smirl wrote:
>[...]
>  extern struct tty_driver *ptm_driver;        /* Unix98 pty masters; for /dev/ptmx */
> @@ -158,21 +157,21 @@ static struct tty_struct *alloc_tty_stru
>  {
>       struct tty_struct *tty;
>
> -     tty = kmalloc(sizeof(struct tty_struct), GFP_KERNEL);
> -     if (tty)
> -             memset(tty, 0, sizeof(struct tty_struct));
> +     tty = kmalloc(sizeof(*tty), GFP_KERNEL);
               ^^^^^^^
kzalloc?

It needs to be cleaned up. Right now it clears the struct twice before
using it, once in tty_alloc and another in tty_init.

I don't know this code very well, so you might be actually changing the
initialization here. On the other hand, this might be just a simple bug...


--
Jon Smirl
[email protected]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux