On Fri, Jul 08, 2005 at 02:34:56PM -0400, John W. Linville wrote: > @@ -301,6 +335,16 @@ pci_set_power_state(struct pci_dev *dev, > udelay(200); > dev->current_state = state; > > + /* According to section 5.4.1 of the "PCI BUS POWER MANAGEMENT > + * INTERFACE SPECIFICATION, REV. 1.2", a device transitioning > + * from D3hot to D0 _may_ perform an internal reset, thereby > + * going to "D0 Uninitialized" rather than "D0 Initialized". > + * In that case, we need to restore at least the BARs so that > + * the device will be accessible to its driver. > + */ > + if (need_restore) > + pci_restore_bars(dev); > + This code doesn't even build, as need_restore isn't a global variable. Care to redo this patch (and merge it with your other one) and resend it? thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [patch 2.6.13-rc2] pci: restore BAR values from pci_set_power_state for D3hot->D0
- From: "John W. Linville" <[email protected]>
- Re: [patch 2.6.13-rc2] pci: restore BAR values from pci_set_power_state for D3hot->D0
- References:
- Re: [patch 2.6.12 (repost w/ corrected subject)] pci: restore BAR values in pci_enable_device_bars
- From: Ivan Kokshaysky <[email protected]>
- Re: [patch 2.6.12 (repost w/ corrected subject)] pci: restore BAR values in pci_enable_device_bars
- From: "David S. Miller" <[email protected]>
- Re: [patch 2.6.12 (repost w/ corrected subject)] pci: restore BAR values in pci_enable_device_bars
- From: Ivan Kokshaysky <[email protected]>
- Re: [patch 2.6.12 (repost w/ corrected subject)] pci: restore BAR values in pci_enable_device_bars
- From: "David S. Miller" <[email protected]>
- Re: [patch 2.6.12 (repost w/ corrected subject)] pci: restore BAR values in pci_enable_device_bars
- From: Ivan Kokshaysky <[email protected]>
- [patch 2.6.13-rc2] pci: restore BAR values from pci_set_power_state for D3hot->D0
- From: "John W. Linville" <[email protected]>
- Re: [patch 2.6.12 (repost w/ corrected subject)] pci: restore BAR values in pci_enable_device_bars
- Prev by Date: [PATCH] ppc32: Fix building of TQM8260 board
- Next by Date: Re: [swsusp] encrypt suspend data for easy wiping
- Previous by thread: Re: [patch 2.6.13-rc2] pci: restore BAR values from pci_set_power_state for D3hot->D0
- Next by thread: Re: [patch 2.6.13-rc2] pci: restore BAR values from pci_set_power_state for D3hot->D0
- Index(es):
