Re: [PATCH] Add schedule_timeout_{interruptible,uninterruptible}{,_msecs}() interfaces

Hi,

On Sat, 23 Jul 2005, Nishanth Aravamudan wrote:

> 	set_current_state(TASK_{,UN}INTERRUPTIBLE);
> 	schedule_timeout(msecs_to_jiffies(some_constant_msecs));
> 
> just have an interface that allows
> 
> 	schedule_timeout_msecs_{,un}interruptible(some_constant_msecs);
> 
> and push the jiffies conversion to common code?

What's wrong with just:

	schedule_timeout_{,un}interruptible(msecs_to_jiffies(some_constant_msecs));

The majority of users use a constant, which can already be converted at 
compile tile.
Additionally such an interface also had to return a ms value and instead 
of that constant conversion, the user is better off to work with jiffies 
directly.

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Add schedule_timeout_{interruptible,uninterruptible}{,_msecs}() interfaces
    • From: Nishanth Aravamudan <[email protected]>

• References:
  • [patch 1/4] drivers/char/ip2/i2lib.c: replace direct assignment with set_current_state()
    • From: [email protected]
  • Re: [patch 1/4] drivers/char/ip2/i2lib.c: replace direct assignment with set_current_state()
    • From: Andrew Morton <[email protected]>
  • [PATCH] Add schedule_timeout_{interruptible,uninterruptible}{,_msecs}() interfaces
    • From: Nishanth Aravamudan <[email protected]>
  • Re: [PATCH] Add schedule_timeout_{interruptible,uninterruptible}{,_msecs}() interfaces
    • From: Arjan van de Ven <[email protected]>
  • Re: [PATCH] Add schedule_timeout_{interruptible,uninterruptible}{,_msecs}() interfaces
    • From: Roman Zippel <[email protected]>
  • Re: [PATCH] Add schedule_timeout_{interruptible,uninterruptible}{,_msecs}() interfaces
    • From: Arjan van de Ven <[email protected]>
  • Re: [PATCH] Add schedule_timeout_{interruptible,uninterruptible}{,_msecs}() interfaces
    • From: Roman Zippel <[email protected]>
  • Re: [PATCH] Add schedule_timeout_{interruptible,uninterruptible}{,_msecs}() interfaces
    • From: Nishanth Aravamudan <[email protected]>

• Prev by Date: Re: [2.6 patch] sound drivers select'ing ISAPNP must depend on PNP && ISA
• Next by Date: Re: [2.6 patch] drivers/net/hamradio/: cleanups
• Previous by thread: Re: [PATCH] Add schedule_timeout_{interruptible,uninterruptible}{,_msecs}() interfaces
• Next by thread: Re: [PATCH] Add schedule_timeout_{interruptible,uninterruptible}{,_msecs}() interfaces
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]