Re: [patch 1/4] drivers/char/ip2/i2lib.c: replace direct assignment with set_current_state()

[email protected] wrote:
>
> @@ -655,7 +655,7 @@ i2QueueCommands(int type, i2ChanStrPtr p
>  			timeout--;   // So negative values == forever
>  		
>  		if (!in_interrupt()) {

I worry about what this driver is trying to do...

> -			current->state = TASK_INTERRUPTIBLE;
> +			set_current_state(TASK_INTERRUPTIBLE);
>  			schedule_timeout(1);	// short nap 

We do this all over the place.  Adding new schedule_timeout_interruptible()
and schedule_timeout_uninterruptible() would reduce kernel size and neaten
things up.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- [PATCH] Add schedule_timeout_{interruptible,uninterruptible}{,_msecs}() interfaces
  - From: Nishanth Aravamudan <[email protected]>
- Re: [patch 1/4] drivers/char/ip2/i2lib.c: replace direct assignment with set_current_state()
  - From: Nish Aravamudan <[email protected]>

References:
- [patch 1/4] drivers/char/ip2/i2lib.c: replace direct assignment with set_current_state()
  - From: [email protected]

Prev by Date: PREEMPT_RT and I-PIPE: the numbers, part 4
Next by Date: Re: 2.6.12.2 -- time passes faster; related to the acpi_register_gsi() call
Previous by thread: [patch 1/4] drivers/char/ip2/i2lib.c: replace direct assignment with set_current_state()
Next by thread: Re: [patch 1/4] drivers/char/ip2/i2lib.c: replace direct assignment with set_current_state()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind]