On Thu, 31 Mar 2005 13:12:35 +0200 Andi Kleen <[email protected]> wrote: > > On Thu, Mar 31, 2005 at 09:10:59PM +1000, Stephen Rothwell wrote: > > On Thu, 31 Mar 2005 12:38:34 +0200 Andi Kleen <[email protected]> wrote: > > > > > > Nack. The generic sys_time still writes to int, not long. > > > That is why x86-64 has a private one. Please keep that. > > > > It writes to a time_t which is a __kernel_time_t which is a long on > > x86-64, isn't it? > > At least in 2.6.10 it writes to int. I was looking at current bk where it looks like this: asmlinkage long sys_time(time_t __user * tloc) { time_t i; struct timeval tv; do_gettimeofday(&tv); i = tv.tv_sec; if (tloc) { if (put_user(i,tloc)) i = -EFAULT; } return i; } I have no idea when it changed. -- Cheers, Stephen Rothwell [email protected] http://www.canb.auug.org.au/~sfr/
Attachment:
pgpqSJrI0PeeW.pgp
Description: PGP signature
- Follow-Ups:
- Re: [patch 2/3] x86_64: remove duplicated sys_time64
- From: Andi Kleen <[email protected]>
- Re: [patch 2/3] x86_64: remove duplicated sys_time64
- References:
- [patch 2/3] x86_64: remove duplicated sys_time64
- From: [email protected]
- Re: [patch 2/3] x86_64: remove duplicated sys_time64
- From: Andi Kleen <[email protected]>
- Re: [patch 2/3] x86_64: remove duplicated sys_time64
- From: Stephen Rothwell <[email protected]>
- Re: [patch 2/3] x86_64: remove duplicated sys_time64
- From: Andi Kleen <[email protected]>
- [patch 2/3] x86_64: remove duplicated sys_time64
- Prev by Date: Re: [PATCH scsi-misc-2.6 10/13] scsi: rewrite scsi_request_fn()
- Next by Date: Re: [patch] Real-Time Preemption, -RT-2.6.12-rc1-V0.7.41-25
- Previous by thread: Re: [patch 2/3] x86_64: remove duplicated sys_time64
- Next by thread: Re: [patch 2/3] x86_64: remove duplicated sys_time64
- Index(es):