the changes look good to me (although I haven't tested any of your patches
yet), but the code flow is rather confusing. What do you think about
the not even compile version of scsi_request_fn() below that should be
functionally identical to yours:
static void scsi_request_fn(struct request_queue *q)
{
struct scsi_device *sdev = q->queuedata;
struct Scsi_Host *shost = sdev->host;
struct scsi_cmnd *cmd;
struct request *req;
enum scsi_device_state state;
int ret = 0;
/*
* FIXME: Once fire & forgetters are fixed, this and the
* unlock_irq/put_device/lock_irq dance at the end of this
* function can go away.
*/
get_device(&sdev->sdev_gendev);
while ((req = elv_next_request(q))) {
int is_special = (req->flags & REQ_SPECIAL), kill = 0;
cmd = req->special;
state = cmd->device->sdev_state;
if (state == SDEV_BLOCK ||
(state == SDEV_QUIESCE && !is_special))
goto out;
else if (state == SDEV_OFFLINE || state == SDEV_DEL ||
(state == SDEV_CANCLE && !is_special)) {
printk(KERN_ERR "scsi%d (%d:%d): "
"rejecting I/O to %s\n",
(state == SDEV_OFFLINE) ?
"offline device" :
((state == SDEV_DEL) ?
"dead device" :
"device being removed"));
kill = 1;
} else if (!scsi_dev_queue_ready(q, sdev))
goto out;
/* Start tag / remove from the request queue. */
if (blk_queue_tagged(q)) {
if (unlikely(blk_queue_start_tag(q, req)))
BUG();
cmd->tag = req->tag;
} else
blkdev_dequeue_request(req);
sdev->device_busy++;
/* Switch to host_lock. */
spin_unlock(q->queue_lock);
scsi_wait_reset(shost);
spin_lock(shost->host_lock);
if (kill || test_bit(SHOST_CANCEL, &shost->shost_state)) {
SCSI_LOG_MLQUEUE(3,
printk("%s: rejecting request\n", __FUNCTION__));
shost->host_busy++;
atomic_inc(&sdev->iorequest_cnt);
cmd->result = DID_NO_CONNECT << 16;
__scsi_done(cmd);
goto relock;
}
if (!scsi_host_queue_ready(q, shost, sdev))
goto requeue_out;
if (sdev->single_lun) {
struct scsi_target *target = scsi_target(sdev);
if (target->starget_sdev_user &&
target->starget_sdev_user != sdev)
goto requeue_out;
target->starget_sdev_user = sdev;
}
shost->host_busy++;
scsi_log_send(cmd);
scsi_cmd_get_serial(shost, cmd);
scsi_add_timer(cmd, cmd->timeout_per_command, scsi_times_out);
cmd->state = SCSI_STATE_QUEUED;
cmd->owner = SCSI_OWNER_LOWLEVEL;
ret = shost->hostt->queuecommand(cmd, scsi_done);
if (ret) {
SCSI_LOG_MLQUEUE(3,
printk("%s: queuecommand deferred request (%d)\n",
__FUNCTION__, ret));
/*
* Timer should be deleted while holding
* the host_lock. Once it gets released, we
* don't know if cmd is still there or not.
*/
if (scsi_delete_timer(cmd)) {
shost->host_busy--;
goto block_requeue_out;
}
spin_unlock_irq(shost->host_lock);
goto out_locked;
}
atomic_inc(&sdev->iorequest_cnt);
relock:
/* Switch back to queue_lock. */
spin_unlock(shost->host_lock);
spin_lock(q->queue_lock);
/* The queue could have been plugged underneath us. */
if (blk_queue_plugged(q))
goto out;
}
goto out;
block_requeue_out:
if (ret == SCSI_MLQUEUE_DEVICE_BUSY)
sdev->device_blocked = sdev->max_device_blocked;
else
shost->host_blocked = shost->max_host_blocked;
requeue_out:
/* Switch back to queue_lock */
spin_unlock(shost->host_lock);
spin_lock(q->queue_lock);
cmd->state = SCSI_STATE_MLQUEUE;
cmd->owner = SCSI_OWNER_MIDLEVEL;
SCSI_LOG_MLQUEUE(3,
printk("%s: requeueing request\n", __FUNCTION__));
req->flags |= REQ_SOFTBARRIER; /* Don't pass this request. */
blk_requeue_request(q, req);
if (--sdev->device_busy == 0)
blk_plug_device(q);
out:
/*
* Must be careful here. If we trigger the ->remove() function
* we cannot be holding the q lock
*/
spin_unlock_irq(q->queue_lock);
out_locked:
put_device(&sdev->sdev_gendev);
spin_lock_irq(q->queue_lock);
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
