Re: [rtc-linux] Re: [PATCH 1/7] Blackfin RTC driver: the frequency function is in units of Hz, not units of seconds, so lock our driver down to 1 Hz

On Tue, 4 Dec 2007 11:47:56 -0500
"Mike Frysinger" <[email protected]> wrote:

> 
> the return of ENOTTY is to say "changing of freq isnt supported", not
> that the value is invalid.  but i can get the same behavior by
> deleting the function as the rtc-dev layer will take care of returning
> ENOTTY.
> 
> so the behavior is for the RTC_IRQP_SET ioctl:
>  - return ENOTTY if you cannot change freq
>    - the rtc-dev layer will do this for you if you do not set irq_set_freq
>  - return EINVAL if the requested freq is not within the capabilities
> of the hardware
> 
> sound about right ?

 yes, it is. I agree about deleting it.


-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [rtc-linux] Re: [PATCH 1/7] Blackfin RTC driver: the frequency function is in units of Hz, not units of seconds, so lock our driver down to 1 Hz
  - From: "Mike Frysinger" <[email protected]>

References:
- [PATCH 0/7] Blackfin On-Chip RTC driver updates
  - From: Bryan Wu <[email protected]>
- [PATCH 1/7] Blackfin RTC driver: the frequency function is in units of Hz, not units of seconds, so lock our driver down to 1 Hz
  - From: Bryan Wu <[email protected]>
- Re: [PATCH 1/7] Blackfin RTC driver: the frequency function is in units of Hz, not units of seconds, so lock our driver down to 1 Hz
  - From: Alessandro Zummo <[email protected]>
- Re: [rtc-linux] Re: [PATCH 1/7] Blackfin RTC driver: the frequency function is in units of Hz, not units of seconds, so lock our driver down to 1 Hz
  - From: "Mike Frysinger" <[email protected]>
- Re: [rtc-linux] Re: [PATCH 1/7] Blackfin RTC driver: the frequency function is in units of Hz, not units of seconds, so lock our driver down to 1 Hz
  - From: Alessandro Zummo <[email protected]>
- Re: [rtc-linux] Re: [PATCH 1/7] Blackfin RTC driver: the frequency function is in units of Hz, not units of seconds, so lock our driver down to 1 Hz
  - From: "Mike Frysinger" <[email protected]>

Prev by Date: Re: [rtc-linux] Re: [PATCH 1/7] Blackfin RTC driver: the frequency function is in units of Hz, not units of seconds, so lock our driver down to 1 Hz
Next by Date: Re: Why does reading from /dev/urandom deplete entropy so much?
Previous by thread: Re: [rtc-linux] Re: [PATCH 1/7] Blackfin RTC driver: the frequency function is in units of Hz, not units of seconds, so lock our driver down to 1 Hz
Next by thread: Re: [rtc-linux] Re: [PATCH 1/7] Blackfin RTC driver: the frequency function is in units of Hz, not units of seconds, so lock our driver down to 1 Hz
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]