Re: [PATCH 1/7] Blackfin RTC driver: the frequency function is in units of Hz, not units of seconds, so lock our driver down to 1 Hz

[Alessandro Zummo <alessandro.zummo@towertech.it>]

On Fri, 23 Nov 2007 18:08:26 +0800
Bryan Wu <bryan.wu@analog.com> wrote:

 Hi, I fannly got some time to review the patches. Seems ok, the
 only question is...

> static int bfin_irq_set_freq(struct device *dev, int freq)
>  {
> -	struct bfin_rtc *rtc = dev_get_drvdata(dev);
>  	stampit();
> -	rtc->rtc_dev->irq_freq = freq;
> -	return 0;
> +	return -ENOTTY;
>  }

 .. why ENOTTY here?

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/