On Tue, 4 Dec 2007 11:29:11 -0500 "Mike Frysinger" <[email protected]> wrote: > > On Dec 4, 2007 11:26 AM, Alessandro Zummo <[email protected]> wrote: > > Bryan Wu <[email protected]> wrote: > > > > Hi, I fannly got some time to review the patches. Seems ok, the > > only question is... > > > > > static int bfin_irq_set_freq(struct device *dev, int freq) > > > { > > > - struct bfin_rtc *rtc = dev_get_drvdata(dev); > > > stampit(); > > > - rtc->rtc_dev->irq_freq = freq; > > > - return 0; > > > + return -ENOTTY; > > > } > > > > .. why ENOTTY here? > > blah, hit "reply" in previous e-mail ... > > that's what the documentation says to do as does every other rtc driver ? > -mike it should be EINVAL. at least it is wat rtc-cmos does when the value is invalid. -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [rtc-linux] Re: [PATCH 1/7] Blackfin RTC driver: the frequency function is in units of Hz, not units of seconds, so lock our driver down to 1 Hz
- From: "Mike Frysinger" <[email protected]>
- Re: [rtc-linux] Re: [PATCH 1/7] Blackfin RTC driver: the frequency function is in units of Hz, not units of seconds, so lock our driver down to 1 Hz
- From: "Mike Frysinger" <[email protected]>
- Re: [rtc-linux] Re: [PATCH 1/7] Blackfin RTC driver: the frequency function is in units of Hz, not units of seconds, so lock our driver down to 1 Hz
- References:
- [PATCH 0/7] Blackfin On-Chip RTC driver updates
- From: Bryan Wu <[email protected]>
- [PATCH 1/7] Blackfin RTC driver: the frequency function is in units of Hz, not units of seconds, so lock our driver down to 1 Hz
- From: Bryan Wu <[email protected]>
- Re: [PATCH 1/7] Blackfin RTC driver: the frequency function is in units of Hz, not units of seconds, so lock our driver down to 1 Hz
- From: Alessandro Zummo <[email protected]>
- Re: [rtc-linux] Re: [PATCH 1/7] Blackfin RTC driver: the frequency function is in units of Hz, not units of seconds, so lock our driver down to 1 Hz
- From: "Mike Frysinger" <[email protected]>
- [PATCH 0/7] Blackfin On-Chip RTC driver updates
- Prev by Date: [git pull] x86 fixes
- Next by Date: Re: [PATCH] VM/Security: add security hook to do_brk
- Previous by thread: Re: [rtc-linux] Re: [PATCH 1/7] Blackfin RTC driver: the frequency function is in units of Hz, not units of seconds, so lock our driver down to 1 Hz
- Next by thread: Re: [rtc-linux] Re: [PATCH 1/7] Blackfin RTC driver: the frequency function is in units of Hz, not units of seconds, so lock our driver down to 1 Hz
- Index(es):
 |