Re: [rtc-linux] Re: [PATCH 1/7] Blackfin RTC driver: the frequency function is in units of Hz, not units of seconds, so lock our driver down to 1 Hz

[Alessandro Zummo <alessandro.zummo@towertech.it>]

On Tue, 4 Dec 2007 11:29:11 -0500
"Mike Frysinger" <vapier.adi@gmail.com> wrote:

> 
> On Dec 4, 2007 11:26 AM, Alessandro Zummo <alessandro.zummo@towertech.it> wrote:
> > Bryan Wu <bryan.wu@analog.com> wrote:
> >
> >  Hi, I fannly got some time to review the patches. Seems ok, the
> >  only question is...
> >
> > > static int bfin_irq_set_freq(struct device *dev, int freq)
> > >  {
> > > -     struct bfin_rtc *rtc = dev_get_drvdata(dev);
> > >       stampit();
> > > -     rtc->rtc_dev->irq_freq = freq;
> > > -     return 0;
> > > +     return -ENOTTY;
> > >  }
> >
> >  .. why ENOTTY here?
> 
> blah, hit "reply" in previous e-mail ...
> 
> that's what the documentation says to do as does every other rtc driver ?
> -mike

 it should be EINVAL. at least it is wat rtc-cmos does when the value
 is invalid.

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/