On Fri, Nov 30, 2007 at 05:10:33PM -0500, Alan Stern wrote:
> On Fri, 30 Nov 2007, Greg KH wrote:
>
> > Ok, how about this:
> > void kobject_init(struct kobject *kobj, struct ktype *ktype);
> >
> > and then:
> > int kobject_add(struct kobject *kobj, struct kobject *parent, const char *fmt, ...);
> >
> > After we call kobject_init() we HAVE to call kobject_put() to clean up
> > properly. So, if kobject_add() fails, we still need to clean up with
> > kobject_put();
>
> You could put that a little less strongly. After kobject_init() you
> SHOULD call kobject_put() to clean up properly, and after kobject_add()
> you MUST call kobject_del() and kobject_put().
No, in looking at the code, you only need to call kobject_del() to clean
everything up properly, if kobject_add() succeeds. No need to call
kobject_put() yet again.
Can someone else verify that this really is correct?
thanks,
greg k-h
p.s. I think it's time to start a "travel to .nz and kick a certain
ex-kernel-developer around a bit" fund...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
