RE: [patch][v2] x86, ptrace: support for branch trace store(BTS)

["Metzger, Markus T" <markus.t.metzger@intel.com>]

>-----Original Message-----
>From: dean gaudet [mailto:dean@arctic.org] 
>Sent: Dienstag, 20. November 2007 16:37
>To: Metzger, Markus T
>Cc: linux-kernel@vger.kernel.org; mingo@elte.hu; 
>hpa@zytor.com; tglx@linutronix.de; ak@suse.de; Siddha, Suresh 
>B; akpm@linux-foundation.org
>Subject: Re: [patch][v2] x86, ptrace: support for branch trace 
>store(BTS)
>
>On Tue, 20 Nov 2007, dean gaudet wrote:
>
>> On Tue, 20 Nov 2007, Metzger, Markus T wrote:
>> 
>> > +__cpuinit void ptrace_bts_init_intel(struct cpuinfo_x86 *c)
>> > +{
>> > +	switch (c->x86) {
>> > +	case 0x6:
>> > +		switch (c->x86_model) {
>> > +#ifdef __i386__
>> > +		case 0xD:
>> > +		case 0xE: /* Pentium M */
>> > +			ptrace_bts_ops = ptrace_bts_ops_pentium_m;
>> > +			break;
>> > +#endif /* _i386_ */
>> > +		case 0xF: /* Core2 */
>> > +			ptrace_bts_ops = ptrace_bts_ops_core2;
>> > +			break;
>> > +		default:
>> > +			/* sorry, don't know about them */
>> > +			break;
>> > +		}
>> > +		break;
>> > +	case 0xF:
>> > +		switch (c->x86_model) {
>> > +#ifdef __i386__
>> > +		case 0x0:
>> > +		case 0x1:
>> > +		case 0x2:
>> > +		case 0x3: /* Netburst */
>> > +			ptrace_bts_ops = ptrace_bts_ops_netburst;
>> > +			break;
>> > +#endif /* _i386_ */
>> > +		default:
>> > +			/* sorry, don't know about them */
>> > +			break;
>> > +		}
>> > +		break;
>> 
>> is this right?  i thought intel family 15 models 3 and 4 
>supported amd64
>> mode...
>
>actually... why aren't you using cpuid level 1 edx bit 21 to 
>enable/disable this feature?  isn't that the bit defined to indicate 
>whether this feature is supported or not?

This function is not checking for the presence of the feature 
but for the BTS record format.
The feature check is done in init_intel().


>and it seems like this patch and perfmon2 are going to have to 
>live with 
>each other... since they both require the use of the DS save area...

Hmmm, this might require some synchronization between those two.

Do you know how (accesses to) MSR's are managed by the kernel?

regards,
markus.

>
>-dean
>
---------------------------------------------------------------------
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen Germany
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer
Registergericht: Muenchen HRB 47456 Ust.-IdNr.
VAT Registration No.: DE129385895
Citibank Frankfurt (BLZ 502 109 00) 600119052

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/