Rusty Russell wrote:
On Saturday 10 November 2007 10:45:38 Anthony Liguori wrote:
The problem is the ABI. We can either require that PCI configuration
values are accessed with natural instructions, or it makes very little
sense to use the PCI configuration space for virtio configuration
information.
To me it seems logical and simplest to allow any accesses, lay out your
structure and emulate it in the obvious way.
Okay, I've got some updates that I'm going to send out now to the PCI
virtio driver but I'll also change it to switch over to a memory
layout. It's not the best PCI ABI but I can certainly live with it.
You can put the configuration information somewhere else, but the PCI config
space seems the logical place.
If we're treating the PCI config space as an opaque memory blob, instead
of as distinct registers, I think it makes more sense to just put it in
memory. In the backend, I have to treat it as a memory blob anyway and
using the PCI config space just means that I have to write all the
various PIO handlers for the different access sizes. It's much more
elegant in my mind just to have the driver provide some memory that the
host fills out.
Thanks for all the review,
Anthony Liguori
Either virtio config looks like a shared memory area (as lguest
currently implements it), or it looks like hardware registers (like
virtio-pci implements it). After thinking about it for a while, I don't
think the two can be reconciled. There are subtle differences between
the two that can't be hidden in the virtio interface. For instance, in
the PCI model, you get notified when values are read/written whereas in
the lguest model, you don't and need explicit status bits.
No. You need those status bits even if you have your register model,
otherwise you can't tell when the configuration as a whole is stable.
Consider the feature bits. Worse, consider extending the feature bits beyond
32 bits.
(We will have to deal with dynamic configuration changes in future; I was
planning on using some status bits. But it's pretty clear that it's going to
require an explicit ack of some form.)
Hope that clarifies,
Rusty.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
