Re: [RFC 13/13] Char: nozomi, cleanup read and write

On 11/10/2007 05:15 PM, Adrian Bunk wrote:
> On Fri, Nov 09, 2007 at 06:51:35PM -0500, Jiri Slaby wrote:
>> ...
>> --- a/drivers/char/nozomi.c
>> +++ b/drivers/char/nozomi.c
>> ...
>> -		if (size_bytes - i == 2) {
>> +		if (unlikely(size_bytes - i == 2)) {
>> ...
> 
> Please don't add likely/unlikely in drivers unless it brings a 
> measurable improvement.

Why? Anyway I think this is the case. The body of the then branch is executed at
most once, while the else branch each time but last. If you write/read 1002
bytes, it means 250:1. ...and it's invoked from interrupt too...

regards,
-- 
Jiri Slaby ([email protected])
Faculty of Informatics, Masaryk University
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [RFC 13/13] Char: nozomi, cleanup read and write
    • From: Adrian Bunk <[email protected]>
  • Re: [RFC 13/13] Char: nozomi, cleanup read and write
    • From: Frank Seidel <[email protected]>

• References:
  • [RFC 1/13] Char: nozomi, remove unneded stuff
    • From: Jiri Slaby <[email protected]>
  • [RFC 13/13] Char: nozomi, cleanup read and write
    • From: Jiri Slaby <[email protected]>
  • Re: [RFC 13/13] Char: nozomi, cleanup read and write
    • From: Adrian Bunk <[email protected]>

• Prev by Date: [git patches] net driver fixes
• Next by Date: Re: [PATCH] virtio config_ops refactoring
• Previous by thread: Re: [RFC 13/13] Char: nozomi, cleanup read and write
• Next by thread: Re: [RFC 13/13] Char: nozomi, cleanup read and write
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]