Re: [RFC 13/13] Char: nozomi, cleanup read and write

On Fri, Nov 09, 2007 at 06:51:35PM -0500, Jiri Slaby wrote:
>...
> --- a/drivers/char/nozomi.c
> +++ b/drivers/char/nozomi.c
>...
> -		if (size_bytes - i == 2) {
> +		if (unlikely(size_bytes - i == 2)) {
>...

Please don't add likely/unlikely in drivers unless it brings a 
measurable improvement.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [RFC 13/13] Char: nozomi, cleanup read and write
    • From: Jiri Slaby <[email protected]>

• References:
  • [RFC 1/13] Char: nozomi, remove unneded stuff
    • From: Jiri Slaby <[email protected]>
  • [RFC 13/13] Char: nozomi, cleanup read and write
    • From: Jiri Slaby <[email protected]>

• Prev by Date: Re: Initrd problem with AMD opteron dual core
• Next by Date: [PATCH] drivers/video/s1d13xxxfb.c as module with dbg
• Previous by thread: Re: [RFC 13/13] Char: nozomi, cleanup read and write
• Next by thread: Re: [RFC 13/13] Char: nozomi, cleanup read and write
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]