Matthew Wilcox wrote:
On Wed, Oct 17, 2007 at 09:09:24AM -0400, Mark Lord wrote:..- temp_word = (temp_word & ~intr_enable) | intr_enable; + temp_word = (temp_word & ~intr_enable) | intr_enable;*boggle*Dig out your text editor, and notice the excess whitespace at the end of the line, along with similar stuff on most other lines in this patch.You, however, did clip the important line.temp_word |= intr_enable;which is what I was saying the above is equivalent to.
Gag-me. That *is* bad. But the PCIe folks seem to be extra sensitive about the code, so I'm trying to change as little as possible here.That line was just the result of doing this in vim: :%s/[ ]*$//g
I agree there's a lot of funny looking code in there, but that's not what this particular patch series is about. You could submit a follow-up patch to repair that stuff, if you like. Mmm.. I wonder how clever gcc is with a line like that.. ? ;) Cheers! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- References:
- Re: PCIe Hotplug: NFG unless I boot with card already inserted.
- From: Mark Lord <[email protected]>
- Re: PCIe Hotplug: NFG unless I boot with card already inserted.
- From: Mark Lord <[email protected]>
- Re: PCIe Hotplug: NFG unless I boot with card already inserted.
- From: Kristen Carlson Accardi <[email protected]>
- Re: PCIe Hotplug: NFG unless I boot with card already inserted.
- From: Mark Lord <[email protected]>
- Re: [Pcihpd-discuss] PCIe Hotplug: NFG unless I boot with card already inserted.
- From: Greg KH <[email protected]>
- [PATCH] Fix PCIe hotplug for Dell notebook ExpressCard slots
- From: Mark Lord <[email protected]>
- [PATCH 0/4] Fix PCIe hotplug for non-ACPI ExpressCard slots (version 2)
- From: Mark Lord <[email protected]>
- [PATCH 1/4] Fix PCIe hotplug for non-ACPI ExpressCard slots (version 2)
- From: Mark Lord <[email protected]>
- Re: [Pcihpd-discuss] [PATCH 1/4] Fix PCIe hotplug for non-ACPI ExpressCard slots (version 2)
- From: Matthew Wilcox <[email protected]>
- Re: [Pcihpd-discuss] [PATCH 1/4] Fix PCIe hotplug for non-ACPI ExpressCard slots (version 2)
- From: Mark Lord <[email protected]>
- Re: [Pcihpd-discuss] [PATCH 1/4] Fix PCIe hotplug for non-ACPI ExpressCard slots (version 2)
- From: Matthew Wilcox <[email protected]>
- Re: PCIe Hotplug: NFG unless I boot with card already inserted.
- Prev by Date: [FB] au1100fb: Fix modpost warnings.
- Next by Date: Re: [PATCH 4/4] fix not-and/or errors
- Previous by thread: Re: [Pcihpd-discuss] [PATCH 1/4] Fix PCIe hotplug for non-ACPI ExpressCard slots (version 2)
- Next by thread: Re: [PATCH 0/4] Fix PCIe hotplug for non-ACPI ExpressCard slots (version 2)
- Index(es):
 |