Re: PCIe Hotplug: NFG unless I boot with card already inserted.

[Mark Lord <lkml@rtr.ca>]

Mark Lord wrote:
> Mark Lord wrote:
> > Kristen Carlson Accardi wrote:
> > > On Tue, 16 Oct 2007 14:39:33 -0400
> > > Mark Lord <lkml@rtr.ca> wrote:
> > >
> > > > I also checked my modprobe.d/ options, and I am using pciehp_force=1.
> > > > Without that flag, none of this ever works.
> > >
> > > OK - I suspected something like this.  Most Dell computers don't support
> > > ExpressCard hotplug using Native PCIe -- in fact, I've not seen a single
> > > one, they explicitly disable it because they have not validated it or
> > > they have and something didn't work right.  I'll take a look at what 
> > > you've
> > > got, but be aware that you are forcing pciehp to load and operate on 
> > > a system
> > > where they've certainly either not tested it, or tested it and something
> > > bad happened.
> >
> > Perhaps.  But this one works perfectly, except for two driver bugs:
> >
> > 1. Driver does not notice already-inserted cards after modprobe.
> > 2. Driver fails to function after suspend/resume until reloaded.
> >
> > Both of those are fixable in the kernel.
>
> Ahh.. point 2 in particular suffers from "suspend/resume" not implemented.
> Or rather, implemented as a pair of "do nothing" functions.

This patch below seems to fix point 1 on my system,
causing pciehp to become aware of already-inserted cards on module load.

It's not perfect, but I believe it does show the kind of functionality
that's missing from the driver.

The resume() function will need something similar, to poll the slots
on resume and call pciehp_enable_slot() or pciehp_disable_slot()
as appropriate.

I suspect this is broken even on machines that do have ACPI BIOS
support.

Cheers

Not for kernel inclusion (yet), but..

Signed-off-by:  Mark Lord <mlord@pobox.com>

--- old/drivers/pci/hotplug/pciehp_core.c	2007-10-12 12:43:44.000000000 -0400
+++ linux/drivers/pci/hotplug/pciehp_core.c	2007-10-16 15:22:46.000000000 -0400
@@ -475,6 +475,9 @@
		rc = t_slot->hpc_ops->power_off_slot(t_slot); /* Power off slot if not occupied*/
		if (rc)
			goto err_out_free_ctrl_slot;
+	} else {
+		extern int pciehp_enable_slot(struct slot *p_slot);
+		pciehp_enable_slot(t_slot);
	}

	return 0;
--- old/drivers/pci/hotplug/pciehp_ctrl.c	2007-10-12 12:43:44.000000000 -0400
+++ linux/drivers/pci/hotplug/pciehp_ctrl.c	2007-10-16 15:22:44.000000000 -0400
@@ -37,7 +37,7 @@
#include "pciehp.h"

static void interrupt_event_handler(struct work_struct *work);
-static int pciehp_enable_slot(struct slot *p_slot);
+       int pciehp_enable_slot(struct slot *p_slot);
static int pciehp_disable_slot(struct slot *p_slot);

static int queue_interrupt_event(struct slot *p_slot, u32 event_type)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/