Re: [PATCH] cpuset and sched domains: sched_load_balance flag fixes

[Andrew Morton <akpm@linux-foundation.org>]

On Wed, 03 Oct 2007 04:44:01 -0700
Paul Jackson <pj@sgi.com> wrote:

> From: Paul Jackson <pj@sgi.com>
> 
> Thanks to Randy Dunlap for the review that caught
> some of the following.
> 
> Some bug fixes and coding style fixes:
>  1) only one statement per line, please.
>  2) don't need to guard kfree() calls with a NULL check
>  3) use kfifo_free, not kfree, if it came from kfifo_alloc
>  4) a pair of curly brackets got lost along the way
>  5) missing .read, .write callbacks for sched_load_balance
> 
> Without (3), one kfifo buffer memory was leaked each time
> one rebuilt scheduler domains
> 
> Without (4), the current task was summarily killed each
> time one tried to rebuild scheduler domains
> 
> Without (5), every read or write system call on a per-cpuset
> special file 'sched_load_balance' failed, EINVAL.
> 
> Signed-off-by: Paul Jackson <pj@sgi.com>
> 
> ---
> 
> Andrew,
> 
>   These fixes go right after the patch they fix:
>     [PATCH] cpuset and sched domains: sched_load_balance flag

I'm getting 100% rejects from this - probably whatever patch it is
patching got lost or unrecognisably mangled.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/