Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()

Zach Brown <[email protected]> wrote:

> /* haha, continuing the fine tradition of terrible names in this  api..  */
> static inline void *PTR_PTR(void *err_ptr) {
> 	BUG_ON(!IS_ERR(err_ptr) || !err_ptr);
> 	return err_ptr;
> }

How about ERR_CAST() instead?  Or maybe CAST_ERR()?

	struct dentry *blah(...)
	{
		struct inode *inode;

		inode = thing(...);
		if (IS_ERR(inode))
			return ERR_CAST(inode);
	}

Where ERR_CAST is defined as:

	static inline void *ERR_CAST(const void *error)
	{
		return (void *) x;
	}

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()
    • From: David Howells <[email protected]>
  • Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()
    • From: Dave Kleikamp <[email protected]>

• References:
  • Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()
    • From: Zach Brown <[email protected]>
  • [PATCH 00/30] Remove iget() and read_inode()
    • From: David Howells <[email protected]>
  • [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()
    • From: David Howells <[email protected]>
  • Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()
    • From: Zach Brown <[email protected]>
  • Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()
    • From: Linus Torvalds <[email protected]>
  • Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()
    • From: Christoph Hellwig <[email protected]>

• Prev by Date: [PATCH] Make DMA-mapping more coherent
• Next by Date: Re: [TOMOYO 05/15](repost) Domain transition handler functions.
• Previous by thread: Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()
• Next by thread: Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]