Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()

On Mon, 1 Oct 2007, Zach Brown wrote:
>
> If you're soliciting opinions, I think I tend to prefer the feel of the
> code paths after the changes.  I don't know the benefits of the change
> are worth the risk in unmaintained file systems, though.
> 
> > +		return ERR_PTR(PTR_ERR(inode));
> 
> This caught my eye.  Surely we can do better :).  It seems to happen a
> few times in the patches, the instance in this patch was the first that
> I noticed.

Yeah. The above obviously *should* be the same as

	return inode;

apart from a few casts. But if the casts matter, there's something else 
wrong.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()
    • From: Christoph Hellwig <[email protected]>

• References:
  • [PATCH 00/30] Remove iget() and read_inode()
    • From: David Howells <[email protected]>
  • [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()
    • From: David Howells <[email protected]>
  • Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()
    • From: Zach Brown <[email protected]>

• Prev by Date: Re: nmi_watchdog fix for x86_64 to be more like i386
• Next by Date: Re: Network slowdown due to CFS
• Previous by thread: Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()
• Next by thread: Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]